Gaining Gain for Personal Gain

SVN commit 911684 by alexmerry:

ReplayGain FTW!

Make replay gain support actually do something by
(a) getting the data we stored out of the collection database
(b) using it when the track changes

Also, improve the storage of replay gain tags by storing NULL when they weren’t present on the original track metadata. This allows us to substitute the track gain for the album gain when the latter is requested but doesn’t exist.

This closes the most popular feature request on bugzilla.

Of course, there’s still work to be done.

  • Currently, it’s fixed in track mode.
  • It only works on files in the collection – it should be possible to extend it to other files on the local computer at least.
  • Finally, it only works on Ogg Vorbis and FLAC files (mp3gain and aacgain modify MP3/MP4 files in such a way that we don’t need to do anything special in Amarok for them to sound right, providing you pass either the “-r” or “-a” option). Adding other file types is simply a case of adding the relevant code to amarokcollectionscanner.

But, right now, I’m listening to my music all playing at the right volume (apart from the WMA files, but what can you do?).

[edit] I should point out that it works without moving your volume slider up and down like the Amarok 1.4 script did.  It just works magically and invisibly, like it should.  This part of the implementation (actually changing the volume) was a doddle, thanks to the wonder of Phonon[/edit]

About these ads

Tags: , , , ,

6 Responses to “Gaining Gain for Personal Gain”

  1. Med Says:

    This is the second wish with a considerable number of votes i see closed in 24 hours (the other one was a kmail wish iirc). Congrats to all developers.

  2. Stu Says:

    Awesome :-) Now I can actually use my flac and vorbis files without volume irritation – well when 2.1 is out anyway

  3. Rasi Says:

    “Finally, it only works on Ogg Vorbis and FLAC files (mp3gain and aacgain modify MP3/MP4 files in such a way that we don’t need to do anything special in Amarok for them to sound right, providing you pass either the “-r” or “-a” option)”

    Sorry, but that sucks… Many, many people hate to alter their original files, which is why they use the tag based approach in mp3 files. You yourself have written about it in your last replaygain related post.
    I, for example ONLY use tags in mp3. (On windows foobar2000 adds them on Linux quodlibet can do it and there are some scripts that can do it too)

  4. Luis Says:

    First of all thanks!

    And a question. I have all my mp3s tagged using mp3gain with the -r option. In Amarok 1.4 using the replaygain script, the volume changes for each track. However, in Amarok 2 this never happens. Are you sure it should work? I just thought that Replay Gain support was needed explicitly in Amarok 2, but since you say this should “just work” for mp3s maybe I’ll have to investigate a bit what’s happening.

  5. Luis Says:

    I investigated a bit and replaygain with mp3s does work. Sorry for the noise above.

    And thanks again.

  6. randomguy3 Says:

    Rasi: as I said, I hope to have MP3 and MP4 replay gain tags being read Real Soon Now. There was always another option for people listening to MP3 and MP4 files, but now there is support those with Ogg Vorbis and FLAC files, for whom the only option was either tags or lossy re-encoding.

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s


Follow

Get every new post delivered to your Inbox.

%d bloggers like this: